This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix thread safety in SubscriptionManager #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection ID is now tracked as a property of the subscription rather than as a separate map, so we can use a single concurrent map to track all details of subscriptions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
SubscriptionManagerwas using toHashMapinstances to track subscription data which isn't thread safe. While subscribe and unsubscribe actions happen on the single vertx event loop thread, retrieving subscriptions and sending messages could happen from any thread depending on which thread notifies of the event (or becausenotifySubscribersOnWorkerThreadwas used).Fix is to move the connection ID into the
Subscriptioninstance so we have a single object containing all the relevant data and can use a single map. That map can then be aConcurrentHashMapto ensure that it can be iterated safely while updates may happen on other threads.