This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Add AT to ensure 0-miner Clique/IBFT are valid #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
approved these changes
Jun 4, 2019
pinges
approved these changes
Jun 4, 2019
jframe
reviewed
Jun 4, 2019
|
|
||
| @Test | ||
| public void startingWithZeroValidatorsProducesValidCluster() throws IOException { | ||
| final String[] validators = {""}; |
There was a problem hiding this comment.
why not just {} as is done for the ibft test?
| public class CliqueZeroValidators extends AcceptanceTestBase { | ||
|
|
||
| @Test | ||
| public void startingWithZeroValidatorsProducesValidCluster() throws IOException { |
There was a problem hiding this comment.
perhaps use shorter test name "zeroValidatorsFormValidCluster" that was used in the Clique test
| final PantheonNode node2 = pantheon.createCliqueNodeWithValidators("node2", validators); | ||
| cluster.start(node1, node2); | ||
|
|
||
| node1.verify(net.awaitPeerCount(1)); |
There was a problem hiding this comment.
should validate both nodes have correct peer count, so cluster.verify(net.awaitPeerCount(1))
|
|
||
| cluster.start(node1, node2); | ||
|
|
||
| node1.verify(net.awaitPeerCount(1)); |
There was a problem hiding this comment.
should validate both nodes have correct peer count, so cluster.verify(net.awaitPeerCount(1))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.