This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Acceptance Test DSL Node refactoring #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
reviewed
May 29, 2019
| @@ -244,9 +245,9 @@ public String getHostName() { | |||
| return LOCALHOST; | |||
| } | |||
|
|
|||
| private JsonRequestFactories jsonRequestFactories() { | |||
| private NodeRequests jsonRequestFactories() { | |||
There was a problem hiding this comment.
perhaps rename method as well, nodeRequestFactories?
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2019 ConsenSys AG. | |||
| * Copyright 2018 ConsenSys AG. | |||
...t/java/tech/pegasys/pantheon/tests/acceptance/dsl/transaction/login/LoginRequestFactory.java
Show resolved
Hide resolved
| @@ -37,4 +42,20 @@ public BigInteger execute(final JsonRequestFactories node) { | |||
| throw new RuntimeException(e); | |||
| } | |||
| } | |||
|
|
|||
| public static class CustomNetJsonRpcRequestFactory { | |||
There was a problem hiding this comment.
any reason to make this an inner class?
There was a problem hiding this comment.
Yeah, not sure why that happened, I'll refactor it
jframe
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Restructuring of the AT DSL, for better encapsulation / logical grouping of behaviours.
Also enforcing consistency across the DSL (different teams introducing different features, using different patterns).
Fixed Issue(s)