This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2560] Add LocalNode class #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
approved these changes
May 23, 2019
| Arrays.asList(Capability.create("eth", 63)), | ||
| 30303, | ||
| BytesValue.fromHexString("0x01")); | ||
| private final int p2pVersion = 5; |
There was a problem hiding this comment.
👍 to making the names of the parameters described in the code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add
LocalNodeclass to hold information about the local node that is not immediately available, but becomes available as the node starts up. This class is convenient because it allows us to pass afinaldependency to classes that need local node data but are constructed before the node is fully up and running.