This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2730] Create MaintainedPeers class #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelStark
approved these changes
May 22, 2019
| peer.getEnodeURL().isListening(), | ||
| "Invalid enode url. Enode url must contain a non-zero listening port."); | ||
| boolean wasAdded = maintainedPeers.add(peer); | ||
| addedSubscribers.forEach(s -> s.onPeerAdded(peer, wasAdded)); |
There was a problem hiding this comment.
Why not invoking subscribers in parallel ? Since there is no particular check in the foreach loop it is doable.
There was a problem hiding this comment.
Leaving this as-is for now because I don't want to get into changing the Subscribers interface.
There was a problem hiding this comment.
You don't have too.
I was just suggesting to do : addedSubscribers.parallelStream().forEach(s -> s.onPeerAdded(peer, wasAdded)); instead of addedSubscribers.forEach(s -> s.onPeerAdded(peer, wasAdded));
|
|
||
| public boolean remove(final Peer peer) { | ||
| boolean wasRemoved = maintainedPeers.remove(peer); | ||
| removedCallbackSubscribers.forEach(s -> s.onPeerRemoved(peer, wasRemoved)); |
| return maintainedPeers.stream(); | ||
| } | ||
|
|
||
| public interface PeerAddedCallback { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Move peer maintenance list management into a new
MaintainedPeersclass. This change will help facilitate the break up of logic withinDefaultP2PNetworkby decoupling the add / remove action from the handling of peers in this list.This change also makes tests more robust by exposing a public dependency that can be checked directly, rather than having to reach into the
DefaultP2PNetworkto check a private field. Some connection-related checks were moved intoDefaultP2PNetwork.connectin order to reduce the amount of custom logic executed when a new peer is added toMaintainedPeers.