This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Optimise TransactionPool.addRemoteTransaction #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of after we sort by nonce and begin iterating.
This was only required because we previously rejected transactions where the nonce was too high.
shemnon
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The transaction pool doesn't add remote transactions until we're in sync. Previously this check was performed after sorting and beginning to iterate the transactions. Move the check to the very start of the method so we bail out as soon as possible.
Additionally, since we no longer reject transactions where the nonce is too high, we don't need to sort the transactions by nonce.