This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Equals cleanup #1434
Merged
Equals cleanup #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't copy collections if we don't need to. Change types higher up if needed. * Don't use Guava's Object.equal, use Java's Objects.equals.
# Conflicts: # pantheon/src/main/java/tech/pegasys/pantheon/cli/EthNetworkConfig.java # pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java # pantheon/src/test/java/tech/pegasys/pantheon/cli/PantheonCommandTest.java # util/src/main/java/tech/pegasys/pantheon/util/enode/EnodeURL.java
mbaxter
approved these changes
May 13, 2019
| @@ -68,7 +68,7 @@ public boolean equals(final Object o) { | |||
| } | |||
| final PreparedCertificate that = (PreparedCertificate) o; | |||
| return Objects.equals(proposalPayload, that.proposalPayload) | |||
| && Objects.equals(new ArrayList<>(preparePayloads), new ArrayList<>(that.preparePayloads)); | |||
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
* Don't copy collections if we don't need to. Change types higher up if needed. * Don't use Guava's Object.equal, use Java's Objects.equals. ** add errorprone test to enforce the banning of Guava's Objects class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)