This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2601] Refactorings and additions to add Account based Smart Contract permissioning #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontractPermissioningController incl. relevant fields etc.
…sioningConfiguration.
Errorific
reviewed
May 9, 2019
| @@ -14,14 +14,14 @@ | |||
|
|
|||
| import tech.pegasys.pantheon.tests.acceptance.dsl.condition.Condition; | |||
| import tech.pegasys.pantheon.tests.acceptance.dsl.node.Node; | |||
| import tech.pegasys.pantheon.tests.acceptance.dsl.transaction.perm.SmartContractNodePermissioningTransactions; | |||
| import tech.pegasys.pantheon.tests.acceptance.dsl.transaction.perm.NodeSmartContractNodePermissioningTransactions; | |||
There was a problem hiding this comment.
NodeSmartContractNodePerm... Node Node node?!
Errorific
reviewed
May 9, 2019
| @@ -18,32 +18,32 @@ | |||
| import tech.pegasys.pantheon.tests.acceptance.dsl.node.Node; | |||
| import tech.pegasys.pantheon.tests.acceptance.dsl.transaction.Transaction; | |||
|
|
|||
| public class SmartContractNodePermissioningTransactions { | |||
| public class NodeSmartContractNodePermissioningTransactions { | |||
There was a problem hiding this comment.
Too much node, just NodeSmartContractPermissioningTransactions sounds fine
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
…ract permissioning (PegaSysEng#1430) * [PAN-2601] Renamed SmartContractPermissioningController -> NodeSmartContractPermissioningController incl. relevant fields etc. * [PAN-2601] Added account smart contract fields to SmartContractPermissioningConfiguration. * [PAN-2601] Added AccountPermissioningProvider. * [PAN-2601] Removed superfluous 'node' from some class and field names. * [PAN-2601] Spotless.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Refactored existing code to accommodate both Node and Account based smart contract permissioning. Added code to support Account based operations.
Fixed Issue(s)
#PAN-2601