Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

IbftProcessor logs when a throwable terminates mining #1427

Merged
merged 4 commits into from
May 13, 2019
Merged

IbftProcessor logs when a throwable terminates mining #1427

merged 4 commits into from
May 13, 2019

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented May 9, 2019

No description provided.

@rain-on rain-on requested review from ajsutton and jframe May 9, 2019 12:22
ajsutton
ajsutton approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Definitely better than losing the errors. We need to work out why those errors aren't printing at some point though because there will be other places unhandled exceptions wind up.

@rain-on rain-on merged commit 81c9a42 into PegaSysEng:master May 13, 2019
@rain-on rain-on deleted the ibft_failure branch May 13, 2019 01:28
notlesh pushed a commit to notlesh/pantheon that referenced this pull request May 14, 2019
@rain-on @notlesh
IbftProcessor logs when a throwable terminates mining (PegaSysEng#1427)
505028f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jframe jframe jframe approved these changes

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rain-on @ajsutton @jframe