This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Change AT discard RPC tests to be more reliable by checking discard using proposals #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
reviewed
May 10, 2019
|
|
||
| validator1.execute(cliqueTransactions.createAddProposal(validator2)); | ||
| validator1.execute(cliqueTransactions.createRemoveProposal(validator3)); | ||
| validator1.verify( |
There was a problem hiding this comment.
Isn't this a race condition? ...as you can't be entire sure of the ordering of the proposals (assuming verify checks ordering)
There was a problem hiding this comment.
It actually builds a map of address, boolean so the order doesn't matter.
| validator2.execute(ibftTransactions.createAddProposal(validator3)); | ||
| validator1.execute(ibftTransactions.createAddProposal(validator2)); | ||
| validator1.execute(ibftTransactions.createRemoveProposal(validator3)); | ||
| validator1.verify( |
There was a problem hiding this comment.
ditto; race condition around request ordering?
CjHare
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Change AT discard RPC tests to be more reliable by checking discard using proposals RPC
Fixed Issue(s)