This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[Minor] Start BlockPropagationManager immediately - don't wait for full sync #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
May 3, 2019
There was a problem hiding this comment.
LGTM. Was concerned about potentially attempting to import blocks before the world state download had completed for a fast sync but the worst case outcome of that is we print a WARN message. It's also exceptionally unlikely and probably indicates something weird going on since the fast sync pivot block is a short distance behind head which would put it out of the range of block propagation manager anyway.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Start
BlockPropagationManagerimmediately - don't wait for full sync.BlockPropagationManageris responsible for listening for block announcements and updating the estimated height and total difficulty of our peers' chains. We need this to be running during fast sync so we can keep an accurate picture of our peers' states.