This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Use streams and avoid iterating child nodes multiple times #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
One of the hot spots in a world state download is calculating the child requests in
TrieNodeDataRequest. Previously it iterated over the nodes twice filtering on an inverse condition - we can replace that with a single loop through the nodes and an if/else. Also switches to returning a Stream instead of a List to avoid needing to collect the children into a list only to then iterate it again.There's still a significant cost in calculating the children because the nodes wind up being serialised to RLP (https://pegasys1.atlassian.net/browse/PAN-2599 logged for that) but the profiler at least suggests this is an improvement.