Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Added txpool pantheon statistics endpoint. #1293

Merged
merged 3 commits into from
Apr 17, 2019

Conversation

rojotek
Copy link
Member

@rojotek rojotek commented Apr 16, 2019

Added the TXPool Pantheon Statistics endpoint to help get insights as to the current state of the transaction pool.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

new JsonRpcRequest(JSON_RPC_VERSION, TXPOOL_PENDING_TRANSACTIONS_METHOD, new Object[] {});

TransactionInfo local = createTransactionInfo(true);
TransactionInfo secondLocal = createTransactionInfo(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: These should all be final.

}

private PendingTransactionsStatisticsResult statistics() {
Set<TransactionInfo> transactionInfo = pendingTransactions.getTransactionInfo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: final

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2019

CLA assistant check
All committers have signed the CLA.

@arash009 arash009 merged commit 0d21510 into PegaSysEng:master Apr 17, 2019
notlesh pushed a commit to notlesh/pantheon that referenced this pull request Apr 24, 2019
* Added txpool pantheon statistics endpoint.

* Added finals.
notlesh pushed a commit to notlesh/pantheon that referenced this pull request May 4, 2019
* Added txpool pantheon statistics endpoint.

* Added finals.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants