This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Allow use of / in branch name when using the branch from tag release job #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
approved these changes
Apr 12, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
I found this issue when testing the "Release: Branch from Tag" for EthSigner (formerly EthFirewall).
This allows the release from branch release job have a / in the branch name being used e.g. release/1.1
Due the use of / as separators in the regular expression to update the job name in the Jenkins.release currently it fails with error "number option to `s' command may not be zero" when using a branch name with a / in it. I've just changed the separator to be # instead of /.
Fixed Issue(s)