This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PIE-1224] Different request limits for different request types #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create `EthLimits` with max size of response according to geth (https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/downloader.go) - update `EthServer` to use those constants limits instead of the default one - remove requestLimit from EthServer and EthProtocolManager constructor fix PIE-1224
- add fields in `SynchronizerConfiguration` to configure per type request limit - update `EthServer` constructor to add new fields - update `EthProtocolManager` and subclasses to support new fields - update unit tests accordingly
…eth-wire-protocol-limits
mbaxter
reviewed
Apr 8, 2019
...eum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/SynchronizerConfiguration.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/manager/EthServer.java
Show resolved
Hide resolved
ethereum/eth/src/test/java/tech/pegasys/pantheon/ethereum/eth/manager/EthServerTest.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/test/java/tech/pegasys/pantheon/ethereum/eth/manager/EthServerTest.java
Outdated
Show resolved
Hide resolved
- remove per type request limit configuration from `SynchronizerConfiguration`. - add `EthServer` constructor without new fields that use default values. - update unit tests accordingly - update instanciation of different `PantheonController` accordingly
mbaxter
approved these changes
Apr 8, 2019
ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/manager/EthServer.java
Outdated
Show resolved
Hide resolved
- spotless - fix clean up review comment
|
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
…SysEng#1224) * [PIE-1224] Different request limits for different request types - create `EthLimits` with max size of response according to geth (https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/downloader.go) - update `EthServer` to use those constants limits instead of the default one - remove requestLimit from EthServer and EthProtocolManager constructor fix PIE-1224 * eth wire protocol request limits - add fields in `SynchronizerConfiguration` to configure per type request limit - update `EthServer` constructor to add new fields - update `EthProtocolManager` and subclasses to support new fields - update unit tests accordingly * Update SynchronizerConfiguration.java * Update EthProtocolManagerTestUtil.java * Update EthServerTest.java * Update EthProtocolManagerTest.java * Update EthServerTest.java * fix after review discussion - remove per type request limit configuration from `SynchronizerConfiguration`. - add `EthServer` constructor without new fields that use default values. - update unit tests accordingly - update instanciation of different `PantheonController` accordingly * Update EthServerTest.java * fix review - spotless - fix clean up review comment * spotlessApply
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
…SysEng#1224) * [PIE-1224] Different request limits for different request types - create `EthLimits` with max size of response according to geth (https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/downloader.go) - update `EthServer` to use those constants limits instead of the default one - remove requestLimit from EthServer and EthProtocolManager constructor fix PIE-1224 * eth wire protocol request limits - add fields in `SynchronizerConfiguration` to configure per type request limit - update `EthServer` constructor to add new fields - update `EthProtocolManager` and subclasses to support new fields - update unit tests accordingly * Update SynchronizerConfiguration.java * Update EthProtocolManagerTestUtil.java * Update EthServerTest.java * Update EthProtocolManagerTest.java * Update EthServerTest.java * fix after review discussion - remove per type request limit configuration from `SynchronizerConfiguration`. - add `EthServer` constructor without new fields that use default values. - update unit tests accordingly - update instanciation of different `PantheonController` accordingly * Update EthServerTest.java * fix review - spotless - fix clean up review comment * spotlessApply
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
SynchronizerConfigurationwith different request limits according to geth (https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/downloader.go)EthServerto use those limits instead of the default oneEthServerandEthProtocolManagerconstructorsFixed Issue(s)
fixes PIE-1224