This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Finish off fast sync pipeline download #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lling the future.
…ask chain downloader to get shutdown working properly.
This reverts commit 089e227.
…-download-loose-ends
mbaxter
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Tidies up the last few loose ends to make the pipeline based chain download work for fast sync. Currently still leaves it toggled off while we run some more detailed real world tests.
SyncStateas the sync target changes so that in-sync listeners are updated appropriately.For the shutdown, we need a separate ticket to tidy up how it should happen - at the moment the
Synchronizergets no notification of shutdown before theEthScheduleris shutdown which cancels all its tasks and things are set up so this is taken as a sign to just silently stop what it's doing. For now, the pipeline chain downloader behaviour matches the EthTask one - if it gets aCancellationExceptionit stops executing but doesn't mark its future as complete.