This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Support async processing while maintaining output order #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
approved these changes
Apr 4, 2019
mbaxter
approved these changes
Apr 4, 2019
| } | ||
|
|
||
| /** | ||
| * CompletableFuture.anyOf adds a completion handler to every future its passed so if we call it |
There was a problem hiding this comment.
Does it help to cancel the future returned from anyOf when you overwrite it??
There was a problem hiding this comment.
Sadly no, it looks like it only cleans the completion stack when the underlying futures complete.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds a
thenProcessAsyncOrderedfunction toPipelineBuilderso that operations can be processed asynchronously, with multiple operations happening concurrently, but ensure that outputs are in the same order as inputs.Also fixes a potential performance issue caused by using
CompletableFuture.anyOftoo much. Each call adds completion actions to the futures involved which are never removed, so when they eventually complete they have a huge stack of actions to notify which can take significant time. Caching the result keeps the number of actions to a reasonable level.Also fixes an issue where the pipeline was not aborted if an asynchronous operation completed exceptionally.
Fixed Issue(s)
https://pegasys1.atlassian.net/browse/PAN-2527