This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Count the number of items discarded when a pipe is aborted #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows monitoring to accurately calculate the number of items in a pipe even after it has aborted.
mbaxter
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
To enable monitoring to calculate the number of items in a pipe, provide a counter of the number of items discarded when the pipe is aborted. Otherwise if a pipeline is aborted and restarted, the counters become confusing because
added - removedis no longer equal to the number of items in the queue. Nowadded - removed - abortedwill give the correct figure (as well as giving an indication of the number of items discarded due to aborts).