Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Simplifying node permissioning ATs #1153

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Simplifying node permissioning ATs #1153

merged 2 commits into from
Mar 22, 2019

Conversation

lucassaldanha
Copy link
Contributor

PR description

  • Removed JSON-RPC specific node permissioning tests
  • Improved NodePermissioning ATs to use available JSON-RPC APIs and assert on the expected outcome of invoking them

ajsutton
ajsutton approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to avoid the cast in the AT though.

.../java/tech/pegasys/pantheon/tests/acceptance/permissioning/NodesWhitelistAcceptanceTest.java Outdated Show resolved Hide resolved
@lucassaldanha lucassaldanha merged commit 409faa9 into PegaSysEng:master Mar 22, 2019
@lucassaldanha lucassaldanha deleted the perm-ats branch March 22, 2019 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @ajsutton