This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Prevent connecting to self #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving an AddPeer, or when loading the static-nodes.json file, pantheon should not accept its own NodeID as a valid connection.
ajsutton
approved these changes
Mar 21, 2019
| */ | ||
| package tech.pegasys.pantheon.ethereum.p2p; | ||
|
|
||
| public class PreventLocalNodeConnection extends RuntimeException { |
There was a problem hiding this comment.
This probably should be more about what went wrong rather than why we don't allow it. So ConnectingToLocalPeerException maybe? Also good to end exception names with Exception (though we break that convention in a few places).
jframe
reviewed
Mar 21, 2019
| @@ -369,6 +370,11 @@ public boolean addMaintainConnectionPeer(final Peer peer) { | |||
| if (!isPeerAllowed(peer)) { | |||
| throw new PeerNotPermittedException(); | |||
| } | |||
|
|
|||
| if (peer.getId().equals(this.getLocalPeerInfo().getNodeId())) { | |||
There was a problem hiding this comment.
nit: the this looks unnecessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving an AddPeer, or when loading the static-nodes.json file, pantheon
should not accept its own NodeID as a valid connection.