Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Refactoring permissioning ATs #1148

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Refactoring permissioning ATs #1148

merged 3 commits into from
Mar 21, 2019

Conversation

lucassaldanha
Copy link
Contributor

PR description

  • Removed all methods in the PantheonNodeFactory that created permissioned nodes
  • Created a PermissionedNodeBuilder to encapsulate all the logic of setting up permissioned nodes
  • Updated all tests that create permissioned nodes to use the new builder

macfarla
macfarla approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely simpler.

@lucassaldanha lucassaldanha merged commit dec3ec3 into PegaSysEng:master Mar 21, 2019
@lucassaldanha lucassaldanha deleted the perm-ats branch March 21, 2019 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macfarla macfarla macfarla approved these changes

@Errorific Errorific Errorific approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucassaldanha @Errorific @macfarla