This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Disconnect peers before the pivot block while fast syncing #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Mar 20, 2019
| @@ -62,6 +66,12 @@ public FastSyncDownloader( | |||
|
|
|||
| private FastSyncState storeState(final FastSyncState state) { | |||
| fastSyncStateStorage.storeState(state); | |||
| if (state.getPivotBlockNumber().isPresent()) { | |||
| trailingPeerRequirements = | |||
There was a problem hiding this comment.
This is a little unexpected in a "storeState" method
There was a problem hiding this comment.
I was thinking along the lines of storing the new trailing peer requirements was storing state but probably is clearer to just have its own method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Automatically configure the trailing peers limit during a fast sync to consider any peer with a chain height below the pivot block to be a trailing peer and having a trailing peer limit of 0. ie disconnect any peers that haven't reached the pivot block because they're useless to us.
After fast sync completes we revert back to the current unlimited trailing peer configuration.