This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
PAN-2286 - quieter exceptions when network is unreachable #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower the log level of discovery connections to unreachable networks, such as a box without IPv6 enabled connecting to an IPv6 peer.
mbaxter
reviewed
Mar 19, 2019
| peer, | ||
| wrapBuffer(packet.encode()), | ||
| err); | ||
| if (err instanceof SocketException && err.getMessage().contains("unreachable")) { |
There was a problem hiding this comment.
Suggested change
| if (err instanceof SocketException && err.getMessage().contains("unreachable")) { | |
| if (err instanceof SocketException && err.getMessage().equals("Network is unreachable")) { |
|
The text varies between platforms. "Network unreachable" also shows up in
other jdk source repos.
…On Tue, Mar 19, 2019, 12:08 PM mbaxter ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/discovery/PeerDiscoveryAgent.java
<#1133 (comment)>:
> @@ -204,11 +205,16 @@ protected void handleOutgoingPacket(final DiscoveryPeer peer, final Packet packe
.whenComplete(
(res, err) -> {
if (err != null) {
- LOG.warn(
- "Sending to peer {} failed, packet: {}",
- peer,
- wrapBuffer(packet.encode()),
- err);
+ if (err instanceof SocketException && err.getMessage().contains("unreachable")) {
⬇️ Suggested change
- if (err instanceof SocketException && err.getMessage().contains("unreachable")) {
+ if (err instanceof SocketException && err.getMessage().equals("Network is unreachable")) {
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1133 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACU3Rc-YjAZmpnyQVGhIslBFd9w09Ccks5vYSengaJpZM4b8vp3>
.
|
mbaxter
approved these changes
Mar 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Lower the log level of discovery connections to unreachable networks,
such as a box without IPv6 enabled connecting to an IPv6 peer.
Fixed Issue(s)
PAN-2286