This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[MINOR] added fromHexStringStrict to check for exactly 20 byte addresses #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
reviewed
Mar 19, 2019
| * | ||
| * @param str An hexadecimal string representing a valid account address (strictly 20 bytes). | ||
| * @return The parsed address. | ||
| * @throws NullPointerException if the provided string is {@code null}. |
There was a problem hiding this comment.
Looks like you return null rather than throw a null pointer exception when the hexstring is null
There was a problem hiding this comment.
and thinking further probably better to throw an illegal argument exception from checkArgument rather than a null pointer
There was a problem hiding this comment.
this is also true for the existing fromHexString method. Do I leave that one as is?
Errorific
approved these changes
Mar 20, 2019
…o cli-strict-address
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Added method to create Address from exactly 20 bytes to be used by CLI (tests remain using existing method which pads shorter values)