Maintain a staticnodes.json #1106
Conversation
The staticnodes.json file resides in the pantheon data directory, is parsed at startup to determine which peers can be connected to (aside from bootnodes), and is updated whenever addPeer/removePeer RPC is invoked. This file is not updated when finding neighbour peers (ONLY on RPC call).
| public class PersistentJsonPeerCache extends PersistentPeerCache { | ||
|
|
||
| private static final Logger LOG = LogManager.getLogger(); | ||
| private static final Charset UTF_8 = Charset.forName("UTF-8"); |
There was a problem hiding this comment.
JDK constant of StandardCharsets.UTF_8 would be a nicer fit
| final Set<EnodeURL> enodes = StaticNodesParser.fromPath(path); | ||
|
|
||
| assertThat(enodes.size()).isEqualTo(4); | ||
| } |
There was a problem hiding this comment.
What about asserting the contents of the endoes list? ...as not just any old four enode IDs will do
| import org.junit.Test; | ||
| import org.junit.rules.TemporaryFolder; | ||
|
|
||
| public class StaticeNodesParserTest { |
| @@ -1161,4 +1164,11 @@ public MetricsSystem getMetricsSystem() { | |||
| public PantheonExceptionHandler exceptionHandler() { | |||
| return exceptionHandlerSupplier.get(); | |||
| } | |||
|
|
|||
| private Set<EnodeURL> loadStaticNodes() throws IOException { | |||
| final String STATIC_NODES_FILENAME = "static-nodes.json"; | |||
There was a problem hiding this comment.
can this be made a constant
There was a problem hiding this comment.
made is a local variable.
|
|
||
| try { | ||
| final JsonArray enodeJsonArray = new JsonArray(new String(staticNodesContent, UTF_8)); | ||
| for (Object jsonObj : enodeJsonArray.getList()) { |
There was a problem hiding this comment.
be nicer to use the jsonArray.stream instead of populating a set
| } | ||
|
|
||
| try { | ||
| final JsonArray enodeJsonArray = new JsonArray(new String(staticNodesContent, UTF_8)); |
There was a problem hiding this comment.
Nit: thinking the code would be cleaner to do something similar to what IbftExtraDataCLIAdapter has done and just use objectMapper and do a objectMapper.readValue(path.toFile(), typedef..) to read it straight to Set and then transform to enodes.
The staticnodes.json file resides in the pantheon data directory,
is parsed at startup to determine which peers can be connected
to (aside from bootnodes), and is updated whenever addPeer/removePeer
RPC is invoked.
This file is not updated when finding neighbour peers (ONLY on RPC
call).