This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Add pipe stage name to thread while executing #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entify when profiling and debugging.
shemnon
approved these changes
Mar 14, 2019
| @@ -49,7 +49,7 @@ | |||
|
|
|||
| Pipeline( | |||
| final Pipe<?> inputPipe, | |||
| final Collection<Runnable> stages, | |||
| final Collection<Stage> stages, | |||
There was a problem hiding this comment.
Why Collection? Does the order of the stages matter? That would imply List.
There was a problem hiding this comment.
It doesn't matter at this point - we're going to execute them all in their own threads anyway. The order of stages is really enforced by the way the pipes connect them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
To make it easier to identify which threads are performing which tasks, pipeline will add the stage name to the end of the thread name while the stage is executing. This makes it much easier to use tools like VisualVM to explore performance.