This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Better bootnodes option error message #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and error Handling this as a method enables to keep the parameter as a string and not a strongly typed value. It then is always accepted by the command line so it's always considered as a param and doesn't raise an unknown param error but also immediately checked against the enode pattern and intelligible matching error is displayed. Converter is removed and only a simple lambda is used in a try block leaving the handling of the error message close to the option thus making code easier to understand. Anyway, as we use a Collection of Strings as input no converter is needed anymore. Update and add tests to check non regression and handle the new behaviour. Also this change can change the order in which options are handled in the spec. So tests are updated to check for the presence of options but not specifying a static order. verifyOptionsConstraintLoggerCall now loops trough the options to check they are contained in the error string but not in a specific order.
NicolasMassart
changed the title
lucassaldanha
approved these changes
Mar 13, 2019
pantheon/src/test/java/tech/pegasys/pantheon/cli/PantheonCommandTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
change --bootnodes option to a method to be able to handle the check and error
Handling this as a method enables to keep the parameter as a string and not a
strongly typed value. It then is always accepted by the command line so it's
always considered as a param and doesn't raise an unknown param error but also
immediately checked against the enode pattern and intelligible matching error
is displayed.
Converter is removed and only a simple lambda is used in a try block
leaving the handling of the error message close to the option thus making code
easier to understand. Anyway, as we use a Collection of Strings as input no
converter is needed anymore.
Update and add tests to check non regression and handle the new behaviour.
Also this change can change the order in which options are handled in the spec.
So tests are updated to check for the presence of options but not specifying a
static order. verifyOptionsConstraintLoggerCall now loops trough the options
to check they are contained in the error string but not in a specific order.
Fixed Issue(s)
fixes PAN-2387 and PAN-2015