This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
[PAN-2345] node permissioning controller #1075
Merged
macfarla
merged 31 commits into
PegaSysEng:master
from
macfarla:pan-2345-node-permissioning-controller
Mar 14, 2019
Merged
[PAN-2345] node permissioning controller #1075
macfarla
merged 31 commits into
PegaSysEng:master
from
macfarla:pan-2345-node-permissioning-controller
Mar 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-node-permissioning-controller
…-node-permissioning-controller
…-node-permissioning-controller
…-node-permissioning-controller
lucassaldanha
suggested changes
Mar 10, 2019
...asys/pantheon/ethereum/permissioning/node/provider/LocalConfigNodePermissioningProvider.java
Outdated
Show resolved
Hide resolved
...main/java/tech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningController.java
Outdated
Show resolved
Hide resolved
...main/java/tech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningController.java
Show resolved
Hide resolved
…-node-permissioning-controller
…-node-permissioning-controller
lucassaldanha
suggested changes
Mar 13, 2019
...ava/tech/pegasys/pantheon/ethereum/permissioning/NodeLocalConfigPermissioningController.java
Outdated
Show resolved
Hide resolved
...in/java/tech/pegasys/pantheon/ethereum/permissioning/NodePermissioningControllerFactory.java
Outdated
Show resolved
Hide resolved
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Show resolved
Hide resolved
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Show resolved
Hide resolved
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Show resolved
Hide resolved
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Outdated
Show resolved
Hide resolved
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerTest.java
Outdated
Show resolved
Hide resolved
For the
The current name of the test methods imply the the |
…-node-permissioning-controller
…ther source OR destination is permitted
lucassaldanha
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Just some optional assertion suggestions.
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Outdated
Show resolved
Hide resolved
...ech/pegasys/pantheon/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Refactor NodeWhitelistController to NodeLocalConfigPermissioningController
Refactored NodePermissioningController to accept multiple providers and check all of them
Added to LocalConfigNodePermissioningController the notion of its own enode URL. The node will not add its own enode to the whitelist.
Fixed Issue(s)
fixes #PAN-2345