This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Expose a synchronous start method in Runner #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e open before it returns but doesn't block until shutdown. Expose an explicit awaitStop method for callers who want to block until Pantheon exits. Fixes intermittency in RunnerTest with thanks to @usmansaleem for reporting via PegaSysEng#1067.
… shutdown properly.
CjHare
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Expose a synchronous start method to Runner.
start()guarantees ports are open before it returns but doesn't block until shutdown. ThenawaitStopcan be used by callers who want to block until Pantheon exits.Fixes intermittency regression in RunnerTest with thanks to @usmansaleem for reporting via #1067.