This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Remove DB init need to use public key subcommand #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabase Creation of the database is useless at this stage, so don't create it as it's usually necessary to remove it if created as we want to use the output of this subcommand to change the genesis that makes the created database useless.
mbaxter
approved these changes
Mar 5, 2019
| } | ||
|
|
||
| @Override | ||
| public void run() { | ||
| spec.commandLine().usage(out); | ||
| } | ||
|
|
||
| @FunctionalInterface | ||
| public interface KeyLoader { |
There was a problem hiding this comment.
(style) Usually internal classes / interfaces go at the bottom of the class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Remove the need to initialise the database when running public key subcommands.
A functional interface is introduced for the keypar loader from file to enable testing of the subcommand by injecting a predefined keypair. The injection takes place in the PantheonCommand class as a method that can be overridden in the test extension of the class.
Unit tests are updated.
Fixed Issue(s)
fixes PAN-2259