This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix ImportBlocksTask to only request from peers that claim to have the blocks #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e chain height it starts requesting from.
mbaxter
approved these changes
Mar 5, 2019
| @@ -96,6 +97,11 @@ protected void executeTaskWithPeer(final EthPeer peer) throws PeerNotConnected { | |||
| }); | |||
| } | |||
|
|
|||
| @Override | |||
| protected Optional<EthPeer> findSuitablePeer() { | |||
There was a problem hiding this comment.
Wonder if its worth it to require subclasses to implement this...
There was a problem hiding this comment.
Interesting. Will take a look at that and follow up with a PR if it works out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
ImportBlocksTask was requesting data from any idle peer without checking that the peer had a chain height above the starting block it was requesting. As a result, peers earlier on the chain would respond with an empty response and risk being disconnected with USELESS_PEER.
Also includes the type of request we made when recording a useless response to make debugging easier.