This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
[PRIV] Get Internal logs and output #1022
Merged
lucassaldanha
merged 12 commits into
PegaSysEng:master
from
vinistevam:internal_logs_events
Mar 13, 2019
Merged
[PRIV] Get Internal logs and output #1022
lucassaldanha
merged 12 commits into
PegaSysEng:master
from
vinistevam:internal_logs_events
Mar 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puneetha17
force-pushed
the
internal_logs_events
branch
3 times, most recently
from
March 4, 2019 15:46
292855f
to
cbb9ca5
Compare
...a/tech/pegasys/pantheon/ethereum/mainnet/precompiles/privacy/PrivacyPrecompiledContract.java
Show resolved
Hide resolved
.../core/src/test-support/java/tech/pegasys/pantheon/ethereum/core/InMemoryStorageProvider.java
Outdated
Show resolved
Hide resolved
.../core/src/test-support/java/tech/pegasys/pantheon/ethereum/core/InMemoryStorageProvider.java
Show resolved
Hide resolved
Puneetha17
force-pushed
the
internal_logs_events
branch
2 times, most recently
from
March 7, 2019 16:48
6935208
to
c8b1957
Compare
lucassaldanha
approved these changes
Mar 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting for feedback on the AT failure. |
- saved in hashmap - should be in db!!!
- includes check for events and output
iikirilov
force-pushed
the
internal_logs_events
branch
3 times, most recently
from
March 13, 2019 18:08
a43ef2a
to
18245ae
Compare
iikirilov
force-pushed
the
internal_logs_events
branch
from
March 13, 2019 18:32
18245ae
to
b357709
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Return the logs and output of internal transaction of a PrivateTx to the eea_PrivateTxReceipt.
Fixed Issue(s)
https://pegasys1.atlassian.net/browse/PRIV-23