This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Remove full hashimoto implementation as its never used #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
reviewed
Feb 28, 2019
|
Is there a reason we would ever use it? And if there is what's the difficulty of going back into the git commits, other than the possibility we all forgot about it or we've had a full turnover of staff? |
|
The lack of testing is probably the biggest reason to remove it but it's also nice to just get rid of code that's not used, as Danno said it's easy to pull back out of git history should we need it in the future. |
shemnon
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
EthHasher.Full is never used except for a single ignored test. Remove it.