This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Address acceptance test intermittency #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajsutton
commented
Feb 28, 2019
•
ajsutton
commented
- Wait for IBFT network to start generating blocks in IbftMiningAcceptanceTest
- Ignore CliqueGetSignersRpcTest. The test is fundamentally flawed expecting the vote it places to appear in a specific block number even though the chain will progress outside of the tests control.
ajsutton
changed the title
rain-on
approved these changes
Feb 28, 2019
|
https://pegasys1.atlassian.net/browse/PAN-2366 has been logged to follow up on CLiqueGetSignersRpcTest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.