This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PRIV] Generate Private Contract Address #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return The generated address of the created private contract. | ||
| */ | ||
| public static Address privateContractAddress( | ||
| final Address senderAddress, final long nonce, final int privacyGroup) { |
There was a problem hiding this comment.
As per our Slack discussion, the privacyGroupID should be calculated as:
keccak256(RLP(address1, address2, ..., addressN))
Should we change this method signature now or is this something that will be refactored later?
vinistevam
force-pushed
the
priv-contract-addr-generation
branch
5 times, most recently
from
c150545
to
3069fb0
Compare
vinistevam
force-pushed
the
priv-contract-addr-generation
branch
from
3069fb0
to
287d178
Compare
vinistevam
force-pushed
the
priv-contract-addr-generation
branch
from
287d178
to
56e86b5
Compare
lucassaldanha
approved these changes
Mar 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Create a new method to use SenderAddress, nonce and PrivacyGroup to generate the private address.
Remove the resolveAccountFromPublicState.
Fixed Issue(s)
PRIV-25