Added test to justify the change

PegaSysEng · Dec 4, 2018 · f8673aa · f8673aa
1 parent 679e20e
commit f8673aa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/consensus/clique/src/main/java/tech/pegasys/pantheon/consensus/clique/VoteTallyCache.java b/consensus/clique/src/main/java/tech/pegasys/pantheon/consensus/clique/VoteTallyCache.java
@@ -109,6 +109,6 @@ private VoteTally constructMissingCacheEntries(
       voteTallyUpdater.updateForBlock(h, mutableVoteTally);
       voteTallyCache.put(h.getHash(), mutableVoteTally.copy());
     }
-    return tally;
+    return mutableVoteTally;
   }
 }
diff --git a/...ensus/clique/src/test/java/tech/pegasys/pantheon/consensus/clique/VoteTallyCacheTest.java b/...ensus/clique/src/test/java/tech/pegasys/pantheon/consensus/clique/VoteTallyCacheTest.java
@@ -74,9 +74,9 @@ public void constructThreeBlockChain() {
     }
     headerBuilder.extraData(
         new CliqueExtraData(
-                BytesValue.wrap(new byte[32]),
-                Signature.create(BigInteger.TEN, BigInteger.TEN, (byte) 1),
-                Lists.emptyList())
+            BytesValue.wrap(new byte[32]),
+            Signature.create(BigInteger.TEN, BigInteger.TEN, (byte) 1),
+            validators)
             .encode());
 
     genesisBlock = createEmptyBlock(0, Hash.ZERO);
@@ -167,12 +167,15 @@ public void integrationTestingVotesBeingApplied() {
 
     final VoteTallyCache cache = new VoteTallyCache(blockChain, tallyUpdater, epochManager);
 
-    final VoteTally initialVoteTally = cache.getVoteTallyAfterBlock(block_1.getHeader());
-    assertThat(initialVoteTally.getValidators()).containsAll(validators);
+    VoteTally voteTally = cache.getVoteTallyAfterBlock(block_1.getHeader());
+    assertThat(voteTally.getValidators()).containsAll(validators);
 
-    final VoteTally finalVoteTally = cache.getVoteTallyAfterBlock(block_2.getHeader());
+    voteTally = cache.getVoteTallyAfterBlock(block_2.getHeader());
 
-    assertThat(initialVoteTally.getValidators())
+    assertThat(voteTally.getValidators())
         .containsExactly(validators.get(0), validators.get(1));
+
+    voteTally = cache.getVoteTallyAfterBlock(block_1.getHeader());
+    assertThat(voteTally.getValidators()).containsAll(validators);
   }
 }