feat: add context propagator and use it to enrich metrics with flow metadata #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamKunalGupta
force-pushed
the
feat/add-flow-metadata-ctx
branch
from
c853a75 to
91652be
Compare
serprex
reviewed
Jan 28, 2025
| func (a *FlowableActivity) GetFlowMetadata(ctx context.Context, flowName string, sourceName string, | ||
| destinationName string) (*shared.FlowMetadata, error) { | ||
| logger := log.With(activity.GetLogger(ctx), slog.String(string(shared.FlowNameKey), flowName)) | ||
| peerTypes, err := connectors.LoadPeerTypes(ctx, a.CatalogPool, []string{sourceName, destinationName}) |
There was a problem hiding this comment.
do we want to cache this somewhere? not sure how often this will hit catalog with the metrics we will add
There was a problem hiding this comment.
This function is meant to be run once by workflows
There was a problem hiding this comment.
missed the shared function my bad
could be a LocalActivity?
There was a problem hiding this comment.
Yep, was thinking the same
iamKunalGupta
force-pushed
the
feat/add-flow-metadata-ctx
branch
from
91652be to
2598e7b
Compare
iamKunalGupta
force-pushed
the
feat/add-flow-metadata-ctx
branch
from
b01f3e4 to
64c7ee8
Compare
serprex
reviewed
Jan 29, 2025
serprex
reviewed
Jan 29, 2025
serprex
reviewed
Jan 29, 2025
flow/workflows/cdc_flow.go
Outdated
| @@ -568,3 +574,15 @@ func CDCFlowWorkflow( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func GetFlowMetadataContext(ctx workflow.Context, flowJobName string, sourceName string, destinationName string) (workflow.Context, error) { | |||
There was a problem hiding this comment.
there's another utility method around in these workflow files (GetSideEffect?), these could be in a util.go
serprex
reviewed
Jan 29, 2025
serprex
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context is propagated as temporal headers:
Metrics automatically have the desired attributes:
