feat: add more metrics #2454
Merged
feat: add more metrics #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Jan 17, 2025
flow/activities/flowable.go
Outdated
| @@ -767,6 +768,19 @@ func (a *FlowableActivity) RecordSlotSizes(ctx context.Context) error { | |||
| return | |||
| } | |||
| slotMetricGauges.IntervalSinceLastNormalizeGauge = intervalSinceLastNormalizeGauge | |||
|
|
|||
| syncedTablesGauge, err := a.OtelManager.GetOrInitInt64Gauge( | |||
| otel_metrics.BuildMetricName(otel_metrics.SyncedTablesGaugeName), | |||
There was a problem hiding this comment.
either now or after we should make RecordGauge utility method on otelmanager
There was a problem hiding this comment.
Yeah, I feel that all gauges/counters can probably be initialized in otel manager. There is no flow specific information when we initialize them
serprex
reviewed
Jan 17, 2025
iamKunalGupta
force-pushed
the
feat/add-more-metrics
branch
3 times, most recently
from
ae6a4d4 to
7c237a5
Compare
iamKunalGupta
force-pushed
the
feat/add-more-metrics
branch
from
de0f6df to
387da4a
Compare
serprex
reviewed
Jan 21, 2025
| a.OtelManager.Metrics.RecordsSyncedGauge.Record(ctx, syncResponse.NumRecordsSynced, metric.WithAttributeSet(attribute.NewSet( | ||
| attribute.String(otel_metrics.FlowNameKey, config.FlowJobName), | ||
| attribute.String(otel_metrics.BatchIdKey, strconv.FormatInt(syncResponse.CurrentSyncBatchID, 10)), | ||
| attribute.String(otel_metrics.SourcePeerType, fmt.Sprintf("%T", srcConn)), |
There was a problem hiding this comment.
in behind %T just uses reflect: https://cs.opensource.google/go/go/+/refs/tags/go1.23.5:src/fmt/print.go;l=699
so if you prefer you could make a function in shared that does the same thing & then have more flexibility such as dropping package prefix or something
There was a problem hiding this comment.
i'm still leaning towards a Type() method, opened #2471 for later
serprex
reviewed
Jan 21, 2025
serprex
reviewed
Jan 21, 2025
serprex
reviewed
Jan 21, 2025
serprex
reviewed
Jan 21, 2025
serprex
reviewed
Jan 21, 2025
serprex
reviewed
Jan 21, 2025
serprex
reviewed
Jan 21, 2025
iamKunalGupta
force-pushed
the
feat/add-more-metrics
branch
from
6fa823d to
e7e55cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few new metrics:
error_emitted- instantaneous gauge of whether an error is beingemitted
errors_emitted- counter of errors emitted over timerecords_synced- number of records synced for every sync batch.synced_tables- number of tables configured in each mirrorinstance_status- a constant1metric every 5 minutes (same frequency as slots) with attributes differentiating the current statusmaintenance_status- a constant1when maintenance is running, also has attributes differentiating the current statusTODO: maybe refactor code so that maybe all gauges/counters are initialized inside the otelManager?
ref #2341