Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stretchable header example #211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

filipengberg
Copy link
Contributor

@filipengberg filipengberg commented Nov 14, 2021

No description provided.

@andreialecu
Copy link
Collaborator

andreialecu commented Jan 15, 2022

Interestingly I think I've just implemented this in #228

You could still add the example however. 🙂

@filipengberg filipengberg marked this pull request as ready for review January 20, 2022 20:57
@filipengberg
Copy link
Contributor Author

filipengberg commented Jan 20, 2022

Thats great!

I updated this PR to only contain the stretchable header example using the prop you added.

The reason I never got to finishing my PR was I encountered an issue where the header would not stretch if you drag down when the list is at its top position. You have to first drag to scroll the list a little bit downwards and then up and the overscroll works. Its seems this issue is still present with your implementation (I see in the example video in #228 that it starts by scrolling down a little bit before scrolling up). Do you have any idea what the reason for this could be and how to fix it? I'd be happy to try to help out fixing it (spent an hour on it last time but did not manage to find any solution 😅 )

@filipengberg filipengberg changed the title Feature/stretchable Add streatchable header example Jan 20, 2022
@filipengberg filipengberg changed the title Add streatchable header example Add stretchable header example Jan 20, 2022
@andreialecu
Copy link
Collaborator

I think that may only happen with Expo for some reason. In my real app I can scroll down with no issues so I didn't investigate it too much.

Do you have that issue in non expo apps?

@filipengberg
Copy link
Contributor Author

@andreialecu You're absolutely right, it does work when I test it in another app. Thats weird, but thanks a lot for pointing that out! Feel free to merge this PR if you want the added example, otherwise you can just close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants