fixes for new check errors in R >= 4.4.0 (models edition) #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dockerfile and model_info.json to Rbuildignore - remove badly outdated vignette - ignore complaint about license formatting - lazyData not needed when no data in package - fix broken crosslink
mdietze
approved these changes
Sep 17, 2024
|
Status: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completes the trawl through check output I started in #3346 and #3350 -- see there for more context.
As before, this PR touches a lot of files, but most changes are pretty simple. Review protip: If reviewing in the browser, use the
[ ] Viewedcheckboxes to collapse each file when you're confident you don't need to look at it more -> makes it easier to review PRs like this one in multiple sessions if needed.Motivation and Context
Review Time Estimate
Types of changes
Checklist: