Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Workflow to run Integration Tests #3213

Merged
merged 45 commits into from
Jan 18, 2024

Conversation

meetagrawal09
Copy link
Collaborator

Description

This PR aims at adding a new workflow to run integration tests for data.atmosphere download functions. These tests are to be scheduled weekly.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meetagrawal09 meetagrawal09 marked this pull request as draft September 6, 2023 18:40
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
@allgandalf
Copy link
Collaborator

allgandalf commented Sep 10, 2023

The updated workflow installs all the required libraries, now can you figure out why we get the following error? :

Error: '"stub"' is not an exported object from 'namespace:mockery'
Execution halted
Error: Process completed with exit code 1.

@meetagrawal09
Copy link
Collaborator Author

mockery::stub is something that a lot of our unit tests depend upon and all of those seem to work fine on CI.

@meetagrawal09
Copy link
Collaborator Author

@mdietze, @infotroph I am getting the following error when trying to have python setup in Github Actions. ERA5 needs the cdsapi python package and I am using pip to install it. Can you please help me in fixing this one.

python: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by python)
python: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.35' not found (required by /__t/Python/3.9.18/x64/lib/libpython3.9.so.1.0)
python: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /__t/Python/3.9.18/x64/lib/libpython3.9.so.1.0)
python: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /__t/Python/3.9.18/x64/lib/libpython3.9.so.1.0)
python: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /__t/Python/3.9.18/x64/lib/libpython3.9.so.1.0)

Resolved it by changing Ubuntu version to 20.04

@meetagrawal09 meetagrawal09 force-pushed the ci-integrationtests branch 2 times, most recently from b817573 to 2539099 Compare November 20, 2023 13:29
@meetagrawal09 meetagrawal09 marked this pull request as ready for review December 26, 2023 10:38
@meetagrawal09
Copy link
Collaborator Author

@mdietze I have updated the PR to run integration tests for all other data items except ERA5 since that requires additional setup to access the CDS API. You can proceed with merging this one so that tests for other data items can run. I will raise another PR for changes needed by ERA5.

Successful test run : Job Link

@mdietze mdietze added this pull request to the merge queue Jan 18, 2024
Merged via the queue into PecanProject:develop with commit 45d1045 Jan 18, 2024
7 of 12 checks passed
@meetagrawal09 meetagrawal09 deleted the ci-integrationtests branch January 19, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants