-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Integration Tests for download.AmerifluxLBL
#3208
Added Integration Tests for download.AmerifluxLBL
#3208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR and the other met download PRs do represent useful tests of whether the underlying APIs we use are responding, they aren't actually integration tests. I'm not even sure they count as unit tests since they're not actually testing the download functions that we're currently using. (aside: I wonder if it'd be possible, once files are downloaded in the current piecemeal fashion, to use them in mocking the responses to the overall function unit tests). More importantly, they current unit tests are definitely not integration testing the larger met.process workflow. As such, I worry that we may be missing opportunities to identify the larger issues in that workflow and are investing time in fixing things that may not be the parts that are actually broken.
Description
This PR aims to add integration tests for the data item :
AmerifluxLBL
Review Time Estimate
Types of changes
Checklist: