-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issues #2955 and #2959 #3010
Conversation
changed to http://pecan.localhost/ from http://localhost:8000/
This still won't catch jobids without a literal space before them (e.g. my old frenemy "ondemand52.aci.ics.psu.edu.568420642 submitted"), but my sense is that in practice every default involving qsub should be thought of less as a value that will work for most people and more as an example of how to specify your own value when the default inevitably fails on your system. Therefore I support merging this as it is. |
Description
Recently @robkooper changed the way the docker install works so that pecan is reached from http://pecan.localhost/ instead of http://localhost:8000/. I've made the changes in the documentation in #2935, but there are still instances of "localhost:8000" in tests, shell scripts,etc. I have made the changes accordingly.
Also I have changed the regex pattern as required.
this fixes issue #2955 and #2959
Review Time Estimate
Types of changes
Checklist: