Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete scripts/qsub_build.sh #3133

Closed
Waer1 opened this issue Mar 11, 2023 · 5 comments · Fixed by #3396
Closed

remove obsolete scripts/qsub_build.sh #3133

Waer1 opened this issue Mar 11, 2023 · 5 comments · Fixed by #3396

Comments

@Waer1
Copy link

Waer1 commented Mar 11, 2023

Bug Description

qsub_build.sh uses install.dependencies.R which is no longer there, It should use install_pecan.sh instead as I thought

https://github.com/PecanProject/pecan/blob/develop/scripts/qsub_build.sh

To Reproduce

Steps to reproduce the behaviour:

  1. Go to ' https://github.com/PecanProject/pecan/blob/develop/scripts '
  2. Click on 'qsub_build.sh'
@mdietze
Copy link
Member

mdietze commented Mar 13, 2023

I'm not sure what qsub_build.sh was for (I can't find anything else calling it or anything in the documentation), but the current script for installing dependencies is docker/depends/pecan.depends.R

Copy link

This issue is stale because it has been open 365 days with no activity.

@dlebauer dlebauer changed the title qsub_build.sh uses non-exist script remove obsolete scripts/qsub_build.sh Jul 24, 2024
@AdarshSahani003
Copy link

I’d like to work on this issue, is anyone currently working on it?

@infotroph
Copy link
Member

infotroph commented Oct 21, 2024

@AdarshSahani003 Go for it! I think the correct resolution is a PR that simply deletes qsub_build.sh and then states in the PR description how you confirmed that it's not used anywhere else in the repo.

@harshagr70
Copy link
Contributor

@infotroph hey !! since there is no updates on this i thought to raise a PR that fixes this particular issue , kindly review it and suggest any changes if needed , i will also attach a detailed description in the PR about why the script is obsolete . Thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants