Generate OSGi metadata into pebble jar to make it OSGi compliant #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use the pebble jar in an OSGi runtime out of the box.
|
@ebussieres could you please have a look at this? |
|
Thank you @ebussieres for accepting this. |
|
I'll make one today |
Awesome. Thanks again! |
|
@HannesWell : Release has been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the pebble jar in an OSGi runtime, like Eclipse, out of the box.
The version ranges for the optional dependencies
com.github.ben-manes.caffeine:caffeine,javax.servletandjakarta.servlethave been widened manually because there are newer versions available than the one this library depends on.If you are interested in updating any of these dependencies (and especially migrate
javax.servlet:servlet-apitojavax.servlet:javax.servlet-apior evenjakarta.servlet:jakarta.servlet-api:4.0.2(which provides thejavax.servletpackages) I can provide a separate PR or do it in this one.The OSGi compliant MANIFEST.MF is only generated for the main
pebbleartifact.If you think this is also relevant for the spring artifacts I can extend the change, but I would not be able to test the result.