Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net5 target framework #234

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add net5 target framework #234

wants to merge 7 commits into from

Conversation

6bee
Copy link

@6bee 6bee commented Aug 5, 2021

This PR is about adding target framework net5.0 and to generate nuget package on release build.

@WrongBit
Copy link

WrongBit commented Aug 8, 2021

What a reason to target raw, clumsy .NET 5 if it's not even ready? No WinForms, no WPF... WHERE you suppose to run FCTB?? Not saying you break project file in favor of 3 developers who use .NET 5 (against thousands who sit on FW 4.8).

@Ericvf
Copy link
Contributor

Ericvf commented Aug 16, 2021

Meanwhile I have no issues with creating a new .NET 5 WinForms project and installing FCTB from Nuget.
Aside from the .NET targeting warning it works as expected.

@6bee
Copy link
Author

6bee commented Sep 28, 2021

Using FCTB.2.16.24 package in a winforms project targetig net5.0-windows gives me the following error/warning:

NU1701 Package 'FCTB 2.16.24' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net5.0-windows7.0'. This package may not be fully compatible with your project.

It might be worth noting the package doesn't even follow the guideline to specify a TFM for the dll in lib folder.

Apparently no one dares to update this project though!? However, having created this PR I see my duty fulfilled in regards of the oh-so-awesome LGPLv3 license terms...

@SjaaLom
Copy link

SjaaLom commented Jan 11, 2022

Would be nice to get rid of the warning when targeting net5. Can someone please approve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants