Fixed compilation for ESP32 and ESP8266 with -Werror=unused-variable #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using OneWire in a larger project of mine (https://github.com/matthias-bs/BresserWeatherSensorTTN). When I added Travis-CI to improve the quality of my own source code, I came across the following problem:
It seams that the variable
reg
is used in macros on some architectures, but not on ESP32 and ESP8266. The default setting for arduino-ci and other CI implementations based on arduino-cli is to treat unused variables as errors, which breaks my CI test.There does not seem to be an easy way to treat included libraries in a different way than your own code.
As a workaround, I added #pragma statements to temporarily switch the compiler to treat the unused variable as warning (just for the offending lines).
Another solution would be to declare the variables only for the architectures which need them.