Fix for issue #415 (play queue stall) #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling queue.setBehaviour(AudioPlayQueue::NON_STALLING) gives a non-zero result if ::play() did not complete; the call must be re-tried later. In this mode ::getBuffer() may return NULL, as documented, and ::playBuffer() will return non-zero if it failed; as for ::play(), when this happens the operation must be re-tried later.
h4yn0nnym0u5e
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #415 by optionally providing error returns from various methods, instead of burning CPU waiting for audio blocks or queue space to free up. Defaults to original behaviour so old code should still work the same. Updated GUI documentation is included.
Adds an example which demonstrates the various modes of operation.