Fix SPDX Identifier and Foundry top-level key #6
Conversation
|
Hi @sambacha thanks for your contribution. Happy to accept the SPDX fix, but regarding changing the Would you like to revert the last commit you made? |
Do you want me to just leave the top level change or revert the entire thing? |
suggested toml config for downstream users: ```toml memory_limit = 33554432 fuzz_max_global_rejects = 65_536 fuzz_max_local_rejects = 16_384 fuzz_runs = 512 ignored_error_codes = [ 1878, 2018, 3420, 3716, ] cache = true cache_path = 'cache' evm_version = 'london' ```
|
amended the offending changes, note that the top level directive of the profile is a requirement now for foundry. If your using the latest forge you will be greeted with a warning message informing you to update the configuration file. |
|
Also, why not make the compiler version min. the requirement at least ^0.8.4? Should I open separate issues? Cheers 🤠 |
Thanks! Just wanted to separate concerns so I can understand the rationale better.
Foundry's moving so fast! I think they should also update this in their READMEs, they're still using https://github.com/foundry-rs/foundry/tree/37e4376cfbf1d2ce35c0c4eb25f7131c9fc1f8e2/config |
Big fan of custom errors too. But I guess it doesn't hurt to keep the pragma to |
PaulRBerg
changed the title
yup, automate all these things otherwise its ngmi
Will open an issue shortly, its related. Thanks! |
Caught this when flattening the contracts into one.