-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pattern-pedia-auth component #9
base: master
Are you sure you want to change the base?
Conversation
@TYueksel I realized that it would be good to have this setup in a different docker-compose file - can you add one? |
Just renamed the existing file to docker-compose.auth.yml |
It doesn't seem to me like a good idea that the whole contents of the docker-compose file is copied into a new one... future changes in the original file need to be copied here. Is there a way that the authentication component is declared in a separate file that extends the original file? |
There are three ways how we could start pattern atlas with the authentication component separately from the original version without authentication, candidates and issues:
I would recommend using the third option, because it seems to me, that this one is fitting best, easily adjustable for the future and less complex than option 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docker-compose.auth.yml
Outdated
JDBC_DATABASE_PASSWORD: patternatlas | ||
LATEX_RENDERER_HOST_NAME: latex-renderer | ||
LATEX_RENDERER_PORT: 5030 | ||
JDBC_DATABASE_NAME: patternatlas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDBC_DATABASE_NAME is a duplicate key
Depends on those two PRs: