Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pattern-pedia-auth component #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

TYueksel
Copy link
Contributor

@TYueksel TYueksel commented Sep 17, 2021

Depends on those two PRs:

docker-compose.yml Outdated Show resolved Hide resolved
@manuwei
Copy link
Contributor

manuwei commented Oct 14, 2021

@TYueksel I realized that it would be good to have this setup in a different docker-compose file - can you add one?

@TYueksel
Copy link
Contributor Author

Just renamed the existing file to docker-compose.auth.yml

@ghareeb-falazi
Copy link

It doesn't seem to me like a good idea that the whole contents of the docker-compose file is copied into a new one... future changes in the original file need to be copied here. Is there a way that the authentication component is declared in a separate file that extends the original file?

@TYueksel
Copy link
Contributor Author

It doesn't seem to me like a good idea that the whole contents of the docker-compose file is copied into a new one... future changes in the original file need to be copied here. Is there a way that the authentication component is declared in a separate file that extends the original file?

There are three ways how we could start pattern atlas with the authentication component separately from the original version without authentication, candidates and issues:

  1. Use 2 docker-compose files (the way it is right now). Depending on which version you want to use, you either run docker-compose.yml or docker-compose.auth.yml.
    • Disadvantage: You already mentioned them.
  2. Use 2 docker-compose files where docker-compose.auth.yml only contains the authentication service. Depending on which version you want to use, you either only run docker-compose.yml or both docker-compose files (reference).
    • Advantage: Future changes are only need to be done in one file.
    • Disadvantage: Configuring and starting is a little bit more complex (even more if other components like this might join in the future), since configurations between the files are merged or overridden. The files are merged in the order they’re specified on the command line, which is a little bit error prune in my opinion.
  3. Use 1 docker-compose file and introduce profiles to the services. In this case we would only need to include the authentication service to a profile. Services without profiles will always start, while services with profiles will only start if they are specified in command line. Depending on which version you want to use, you either run docker-compose up to run everything without the authentication service or docker-compose --profile auth up to run everything including the authentication service (reference).

I would recommend using the third option, because it seems to me, that this one is fitting best, easily adjustable for the future and less complex than option 2.

Copy link
Member

@lharzenetter lharzenetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JDBC_DATABASE_PASSWORD: patternatlas
LATEX_RENDERER_HOST_NAME: latex-renderer
LATEX_RENDERER_PORT: 5030
JDBC_DATABASE_NAME: patternatlas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDBC_DATABASE_NAME is a duplicate key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants